search

MiguelCastillo / Brackets-Themes

Brackets themes!
Other
138 stars 44 forks source link

Custom scrollbars not working #96

Closed patryk-uszynski closed 10 years ago

patryk-uszynski commented 10 years ago

Hey, i have the newest version of Brackets and the custom scrollbars option nopt working. I have checked the checkbox in settings and I dont see any diffrence.

MiguelCastillo commented 10 years ago

@kr4SHh Hi so what that flag does is that it will enable/disable the scrollbars defined by the current theme you are using, only if the theme specifies a scrollbar. If the theme does not have a scrollbar then the flag will do nothing.

patryk-uszynski commented 10 years ago

@MiguelCastillo Can you give me an example of theme with custom scrollbars?

MiguelCastillo commented 10 years ago

Sure, try pixie. The behavior is indeed a bit odd... That just due to the way that the browser is handling adding and removing scrollbar styling

patryk-uszynski commented 10 years ago

Thanks. You have right, its working ; )

MiguelCastillo commented 10 years ago

Awesome, thanks for checking.

mauricederegt commented 10 years ago

So why is the default dark theme of brackets not having custom scrollbars? A bit darker would be better suiting

patryk-uszynski commented 10 years ago

but... default dark theme of brackets have custom scrollbars.

mauricederegt commented 10 years ago

okay, then they are not working here, I see no difference between the light and dark theme with the scrollbars...

patryk-uszynski commented 10 years ago

Yes, here they are not working because no one made them ;p Try the built-in themes in newest brackets version :)

mauricederegt commented 10 years ago

got latest version (42) So the default dark theme needs an update...

MiguelCastillo commented 10 years ago

@kr4SHh Brackets customizes the scrollbars, you are correct, but it matches the OS default scrollbars. Those cannot be disabled.

What this disable scrollbars setting does is remove scrollbars that are defined in a theme, because those can be can customized in much the same way that Brackets does under the covers.

https://github.com/adobe/brackets/blob/master/src/styles/brackets_codemirror_override.less#L142