search

MikeLankamp / fpm

C++ header-only fixed-point math library
https://mikelankamp.github.io/fpm
MIT License
650 stars 79 forks source link

Fix multiple warnings #6

Closed haberturdeur closed 3 years ago

haberturdeur commented 3 years ago

Hi, I commented some unused variables and local typedef (which for some reason default configured PlatformIO treats as error, when they are needed they can be always brought back)

I guess that the 0 in the switch is supposed to work as a sanity check, but is it necessary? Again it got treated as an error for me, so that's why I replaced it with default, which also removed the warnings about missing enum members because the auto treated them as such.

MikeLankamp commented 3 years ago

Hi @haberturdeur, thanks for fixing these! A small request: could you please simply remove unused variables/local typedefs instead of commenting them out? The rest looks good!