search

MinaSamir11 / react-native-in-app-review

The Google Play In-App Review API, App store rating API lets you prompt users to submit Play Store or App store ratings and reviews without the inconvenience of leaving your app or game.
MIT License
647 stars 57 forks source link

Updated podspec to work on non static builds #126

Closed TaylorDale closed 1 year ago

TaylorDale commented 1 year ago

The dependency is React-Core not React and this caused it to break when using use_frameworks! In the main podfile :)

On Tue, 26 July 2022, 9:17 pm Mina Samir, @.***> wrote:

@.**** requested changes on this pull request.

Please can you mention the error before fixing it to add it in the release notes !? Thank you in advance

— Reply to this email directly, view it on GitHub https://github.com/MinaSamir11/react-native-in-app-review/pull/126#pullrequestreview-1050805459, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABJ66LAEILU4PESEZUYWU33VV7CMFANCNFSM54NP6U6A . You are receiving this because you authored the thread.Message ID: @.*** com>

jedashford commented 1 year ago

@MinaSamir11 You may want to run a release with this change included. With .69.x this library build fails without this. Errors are not helpful: symbol(s) not found for architecture x86_64

With this change though, all works well

MinaSamir11 commented 1 year ago

@MinaSamir11 You may want to run a release with this change included. With .69.x this library build fails without this. Errors are not helpful: symbol(s) not found for architecture x86_64

With this change though, all works well

Will upload new release next days.