search

MinaSamir11 / react-native-in-app-review

The Google Play In-App Review API, App store rating API lets you prompt users to submit Play Store or App store ratings and reviews without the inconvenience of leaving your app or game.
MIT License
646 stars 56 forks source link

Update Play Core Library for Android 14 Compatibility #175

Open HarshitMadhav opened 1 week ago

HarshitMadhav commented 1 week ago

Firstly, thank you for this package @MinaSamir11 and the maintainers!

Issue Description: There is an important compatibility issue with the current version of the Play Core library (com.google.android.play:core) and the upcoming Android 14 (targetSdkVersion 34).

Problem: Google has introduced a backwards-incompatible change to broadcast receivers in Android 14 to improve user security. As a result, the current version of the Play Core library (core:1.9.0) is incompatible with targetSdkVersion 34. This incompatibility will cause crashes and other issues in apps targeting Android 14.

Impact: Target SDK Requirement: From August 31, Google Play requires all new app releases to target Android 14. Release Block: Apps using the current version of the Play Core library will not be able to release future versions to production or open testing. User Security: The security improvements in Android 14 are crucial for user protection, and maintaining compatibility is essential.

Required Action: Please update the Play Core Maven dependency to an Android 14 compatible version. This will ensure that applications using this library can continue to be released on the Google Play Store without any issues.

Reference: Play Core Migration Guide

HarshitMadhav commented 1 week ago

I have raised a Pull Request for this fix here https://github.com/MinaSamir11/react-native-in-app-review/pull/176

Durkaen commented 1 week ago

same here

Screenshot 2024-06-21 at 11 41 12

HarshitMadhav commented 1 week ago

@Durkaen you can use the fix as I have added in the PR

MinaSamir11 commented 1 week ago

I will checkout your pull request.

MinaSamir11 commented 1 week ago

@Durkaen It seems that you are using the previous version, please checkout and mention your installed in-app-review version & update it to the latest version.

Thanks

HarshitMadhav commented 1 week ago

@MinaSamir11 I am running on 4.3.3v

manualexSP commented 6 days ago

Hey guys, I'm having the same issues as well, any news? I noticed that the PR created for this issue was closed.

MinaSamir11 commented 5 days ago

Hey guys, I'm having the same issues as well, any news? I noticed that the PR created for this issue was closed.

Already fixed in the latest version 4.3.3 & please checkout if you're using another lib already using play core.

manualexSP commented 5 days ago

Yeah, it's all good :D Google mentioned a list of versions and I didn't notice that the current version is not on that list 😭

talharasool commented 4 days ago

@HarshitMadhav @MinaSamir11 Hey guys I am on the latest version but still facing issue in android. In the console it shows that it's working but the popup didn’t appear in debug mode and internal testing any solution for it?

MinaSamir11 commented 4 days ago

@HarshitMadhav @MinaSamir11 Hey guys I am on the latest version but still facing issue in android. In the console it shows that it's working but the popup didn’t appear in debug mode and internal testing any solution for it?

Please read well the readme file, to solve your issue.