Closed HarshitMadhav closed 1 week ago
Looks like this is not the correct way. In the migration they are saying -
// In your app’s build.gradle file:
...
dependencies {
// This dependency is downloaded from the [Google’s Maven repository](https://developer.android.com/studio/build/dependencies#google-maven).
// Make sure you also include that repository in your project's build.gradle file.
implementation 'com.google.android.play:review:2.0.1'
// For Kotlin users, also add the Kotlin extensions library for Play In-App Review:
implementation 'com.google.android.play:review-ktx:2.0.1'
...
}
Please checkout and mention your installed version of in-app-review because it was fixed in the current version.
Thanks
@MinaSamir11 Yeah, it's fixed in the latest version.
I was running on ^4.3.3
version
@aadityapaliwal94 currently in the version 4.3.3 I can see this:
dependencies {
implementation "com.google.android.play:review:${safeExtGet('playReviewVersion')}"
implementation "com.google.android.gms:play-services-base:${safeExtGet('playServicesVersion')}"
}
which I think is correct as per your comment.
@aadityapaliwal94 currently in the version 4.3.3 I can see this:
dependencies { implementation "com.google.android.play:review:${safeExtGet('playReviewVersion')}" implementation "com.google.android.gms:play-services-base:${safeExtGet('playServicesVersion')}" }
which I think is correct as per your comment.
exactly this is the latest version of the play review, no need to make any changes, till now.
@MinaSamir11 but there is a mail from Google regarding the same to update the play core services for the android 14
maybe another package implementing play core
@MinaSamir11 when I updated the play core for this package it worked fine, all I had to do was to update the play core version as shown in the PR
by the way, this property you updated didn't work with the project & will be removed next release version.
Till the next version is updated and released for the package, I think we can update the play core to use the latest version so this compatibility issue is resolved.
FIX: Android 14 compatibility issue https://github.com/MinaSamir11/react-native-in-app-review/issues/175