MinaSamir11 / react-native-in-app-review

The Google Play In-App Review API, App store rating API lets you prompt users to submit Play Store or App store ratings and reviews without the inconvenience of leaving your app or game.
MIT License
646 stars 56 forks source link

Update Play Core Library for Android 14 Compatibility #176

Closed HarshitMadhav closed 1 week ago

HarshitMadhav commented 1 week ago

FIX: Android 14 compatibility issue https://github.com/MinaSamir11/react-native-in-app-review/issues/175

aadityapaliwal94 commented 1 week ago

Looks like this is not the correct way. In the migration they are saying -

  1. Remove any imports of the old Play Core libraries in your build.gradle file.
  2. Integrate the Play In-App Review Library
// In your app’s build.gradle file:
...
dependencies {
    // This dependency is downloaded from the [Google’s Maven repository](https://developer.android.com/studio/build/dependencies#google-maven).
    // Make sure you also include that repository in your project's build.gradle file.
    implementation 'com.google.android.play:review:2.0.1'

    // For Kotlin users, also add the Kotlin extensions library for Play In-App Review:
    implementation 'com.google.android.play:review-ktx:2.0.1'
    ...
}
MinaSamir11 commented 1 week ago

Please checkout and mention your installed version of in-app-review because it was fixed in the current version.

Thanks

aadityapaliwal94 commented 1 week ago

@MinaSamir11 Yeah, it's fixed in the latest version.

HarshitMadhav commented 1 week ago

I was running on ^4.3.3 version

HarshitMadhav commented 1 week ago

@aadityapaliwal94 currently in the version 4.3.3 I can see this:

dependencies {
    implementation "com.google.android.play:review:${safeExtGet('playReviewVersion')}"
    implementation "com.google.android.gms:play-services-base:${safeExtGet('playServicesVersion')}"
}

which I think is correct as per your comment.

MinaSamir11 commented 1 week ago

@aadityapaliwal94 currently in the version 4.3.3 I can see this:

dependencies {
    implementation "com.google.android.play:review:${safeExtGet('playReviewVersion')}"
    implementation "com.google.android.gms:play-services-base:${safeExtGet('playServicesVersion')}"
}

which I think is correct as per your comment.

exactly this is the latest version of the play review, no need to make any changes, till now.

HarshitMadhav commented 1 week ago

@MinaSamir11 but there is a mail from Google regarding the same to update the play core services for the android 14

MinaSamir11 commented 1 week ago

maybe another package implementing play core

HarshitMadhav commented 1 week ago

@MinaSamir11 when I updated the play core for this package it worked fine, all I had to do was to update the play core version as shown in the PR

MinaSamir11 commented 1 week ago

by the way, this property you updated didn't work with the project & will be removed next release version.

HarshitMadhav commented 5 days ago

Till the next version is updated and released for the package, I think we can update the play core to use the latest version so this compatibility issue is resolved.