Crash on Android when PlayStore is disabled

MinaSamir11 / react-native-in-app-review

The Google Play In-App Review API, App store rating API lets you prompt users to submit Play Store or App store ratings and reviews without the inconvenience of leaving your app or game.

MIT License

652 stars 58 forks source link

Crash on Android when PlayStore is disabled #20

Closed ogard closed 3 years ago

ogard commented 3 years ago

Steps to reproduce:

Settings -> Apps -> Google Play Store -> Disable
Trigger rating from app using this library
App crashes

Environment:

react-native: "0.63.4"
Android SDK Build Tools: "29.0.5"
Device android version: "7.0"

ogard commented 3 years ago

Looks to me that task.getResult().toString() throws unhandled exception com.google.android.play.core.tasks.RuntimeExecutionException: com.google.android.play.core.internal.aq: Failed to bind to the service., which further makes app to crash. File: AppReviewModule.java, line 59

MinaSamir11 commented 3 years ago

Can you try the new version react-native-in-app-review@2.1.6 and give me feedback?

ogard commented 3 years ago

@MinaSamir11 Still the same. There is unhandled exception in msg argument of Log.e. I'll make PR and add you as reviewer.

MinaSamir11 commented 3 years ago

Thank you. Branch merged and changes is live now @2.1.7.