MinaSamir11 / react-native-in-app-review

The Google Play In-App Review API, App store rating API lets you prompt users to submit Play Store or App store ratings and reviews without the inconvenience of leaving your app or game.
MIT License
665 stars 62 forks source link

Do not hardcode play-services versions #43

Closed cristianoccazinsp closed 3 years ago

cristianoccazinsp commented 3 years ago

Current build.gradle file has implementation 'com.google.android.gms:play-services-base:17.5.0'.

This can be problematic if other incompatible libraries are used, please make this a build time variable, similar to what other libraries do. For instance:

def safeExtGet(prop, fallback) {
    rootProject.ext.has(prop) ? rootProject.ext.get(prop) : fallback
}

dependencies {
  implementation "com.facebook.react:react-native:${safeExtGet('reactNativeVersion', '+')}"
  implementation "com.android.installreferrer:installreferrer:${safeExtGet('installReferrerVersion', '1.1.2')}"
}

Latest version: https://developers.google.com/android/guides/setup

cristianoccazinsp commented 3 years ago

@MinaSamir11 was this addressed?

MinaSamir11 commented 3 years ago

Thank you @cristianoccazinsp
You are right.

I do it in compileSdkVersion & targetSdkVersion,.. I forget to add it to lib.