search

MinaSamir11 / react-native-in-app-review

The Google Play In-App Review API, App store rating API lets you prompt users to submit Play Store or App store ratings and reviews without the inconvenience of leaving your app or game.
MIT License
648 stars 58 forks source link

Remove buildToolsVersion #64

Closed sonywijaya closed 2 years ago

sonywijaya commented 2 years ago

https://github.com/MinaSamir11/react-native-in-app-review/blob/217527fe17324e531f91391804fd83191eaa44f7/android/build.gradle#L32

I can't build the android project when I don't set buildToolsVersion in my project Is it possible that you remove it? Since it's optional

MinaSamir11 commented 2 years ago
sonywijaya commented 2 years ago
  • It takes the build tools version from your project if it does not exist it fallback to the defaults value which is 28.0.3.
  • Please list your error here maybe we can find another sol. since no one yet has the same issue build tools version to remove it.

I think the easiest solution is to set buildToolsVersion on my project or delete the buildToolsVersion safeExtGet('buildToolsVersion') code from my node modules

MinaSamir11 commented 2 years ago

Node modules every time will overide your changes, after run npm install

You have to define build tools version on your project.

Thank you if you have any Questions youare welcomed.