search

MinaSamir11 / react-native-in-app-review

The Google Play In-App Review API, App store rating API lets you prompt users to submit Play Store or App store ratings and reviews without the inconvenience of leaving your app or game.
MIT License
648 stars 58 forks source link

Crashes on iOS (EXC_BAD_ACCESS) when no network calling InAppReview.RequestInAppReview() #68

Closed fivecar closed 2 years ago

fivecar commented 2 years ago

Repro:

  1. Put phone in airplane mode on iOS
  2. Call InAppReview.RequestInAppReview()

Result: EXC_BAD_ACCESS in JavaScriptCore:JSStringRetain. App crashes.

Expected: InAppReview.RequestInAppReview() should not crash the app even if the phone is not connected to the internet.

fivecar commented 2 years ago

Interestingly, this also happens in react-native-store-review as well. Perhaps it's an iOS bug?

fivecar commented 2 years ago

Ack - apologies. I think it's unrelated -- I removed the call and the app still crashes.