MinaSamir11 / react-native-in-app-review

The Google Play In-App Review API, App store rating API lets you prompt users to submit Play Store or App store ratings and reviews without the inconvenience of leaving your app or game.
MIT License
647 stars 57 forks source link

Upgrading to 0.67.2 with expo 44 breaks iOS build #96

Closed quachdev closed 2 years ago

quachdev commented 2 years ago

Receiving an error when trying to build iOS -- Duplicate interface definition for class 'RCTModuleRegistry'

Seems related to: https://github.com/expo/expo/issues/15622

Adding expo_patch_react_imports does not work either. It looks related to RNInAppReviewIOS-Bridging-Header.h? Edit: No, downgrading to SDK 43 and back to SDK 44 seemed to run the patch properly and this does not look to be the issue.

Screen Shot 2022-02-04 at 4 07 25 PM
alantoa commented 2 years ago

same issue

alantoa commented 2 years ago

@quachdev Hi, you can try expo-store-review

lutakyn commented 2 years ago

I'm using react native version 0.66 and it's breaking on iOS. No specific error given.

alantoa commented 2 years ago

@lutakyn Hi! It is recommended that you use https://docs.expo.dev/versions/latest/sdk/storereview/

MinaSamir11 commented 2 years ago

If you use Expo to create a project, you can create a development build for your project using EAS Build or eject to the bare workflow.

lutakyn commented 2 years ago

I'm not using expo

MinaSamir11 commented 2 years ago

Issue resolved in V3.3.3 Give me feedback, Thanks