search

Mindinventory / drop_down_list

Highly versatile Widget to search through a single or multiple choices from bottom sheet list in a dialog box or a menu.
https://www.mindinventory.com/flutter-app-development.php
MIT License
75 stars 32 forks source link

Why make this dynamic? #12

Closed mcorrigan closed 1 year ago

mcorrigan commented 1 year ago

https://github.com/Mindinventory/drop_down_list/blob/c5ca5ce2dd0a2f10d2f5b4ed1e98b1a44ea6f3fa/lib/src/drop_down.dart#L124

Seems like it would be cleaner to keep it typed like the list these are coming from. Is there something I'm missing?

sahilmind commented 1 year ago

@mcorrigan Thanks for the suggestion I have updated selectedNameList from dynamic to SelectedListItem in drop_down_list: 0.0.5 please have a look. I am happy to help you if required. Thanks!

mcorrigan commented 1 year ago

Hey awesome! I forked and changed it on my end, I just found it odd that it wasn't typed and wondered if there was something I needed to learn about in dart. 👍