search

Mindinventory / drop_down_list

Highly versatile Widget to search through a single or multiple choices from bottom sheet list in a dialog box or a menu.
https://www.mindinventory.com/flutter-app-development.php
MIT License
75 stars 32 forks source link

Search breaks listItemBuilder #16

Closed MrLightful closed 7 months ago

MrLightful commented 1 year ago

Search outputs the sublist of the items. This means that indexes from the original list are no longer aligned with this sublist. So when I search, it outputs, for example, a match with one item that is being built by index 0. And there is no way for me to actually know what this item is. It should at least pass over SelectedListItem in listItemBuilder instead of index, so I can match it by value in the original list.

jaydeepkaria-mi commented 9 months ago

We have updated it in the latest version drop_down_list: ^0.0.6 . Please check it. As of now closing this issue.

MrLightful commented 9 months ago

I don't see anything in v0.0.6 that would be a fix for the issue. But maybe I'm missing something? In this case, would appreciate a hint where to look.

Moreover, CHANGELOG says that v0.0.6 fixes #14, #18, #15, #13. This is #16, so maybe @jaydeepkaria-mi you closed it by mistake?

Please consider PR #17 as a fix.

MrLightful commented 8 months ago

@jaydeepkaria-mi please reopen (cc: @deep-mindinventory )

MrLightful commented 7 months ago

@jaydeepkaria-mi any updates?