search

Miorey / wow-model-viewer

A library for displaying interactive 3D models of World of Warcraft characters, items, and NPCs on your website using data from Wowhead. Customize the display with control over camera angles and animation.
https://miorey.github.io/wow-model-viewer/
57 stars 32 forks source link

Remove jQuery/Axios dependencies #9

Closed asfo closed 2 years ago

asfo commented 2 years ago

I see that jQuery is used for ajax requests and for a selector.

Maybe it could change that the selector states something like document.getElementById() and wrap everything with an alert that states the selector was not able to find that id.

And the Ajax requests are being done using the fetch JS API instead of Axios or jQuery.

So this project can work without any third-party dependencies or anything attached to it. In the end looks like it is a wrapper of the Zaml WoW Model Viewer which at least, make it easier to work with but there is no need to work with jQuery or Axios here.

Btw, I can work with that if you want.

Miorey commented 2 years ago

@asfo I didn't test this part, it remains when I extract the code from our server codebase. Any help is welcome, I have few time for this little lib and I would like prioritise the addition of mounts and orientation management.

Miorey commented 2 years ago

@asfo I add you to the project