search

MirrorYuChen / mnn_example

alibaba MNN, mobilenet classifier, centerface detecter, ultraface detecter, pfld landmarker and zqlandmarker, mobilefacenet
MIT License
202 stars 61 forks source link

Why image source format being RGBA instead of BGR. Also probable bug in aligner? #14

Closed kafan1986 closed 4 years ago

kafan1986 commented 4 years ago

In landmarker code, a previous change was reverted. May I know why? Seems like it should be BGR as per the testing code example, instead it is currently RGBA.

Also, for the aligner code for case 106: https://github.com/MirrorYuChen/mnn_example/blob/fd213672f649a0de3b758389e9f99b02a3906206/src/face/aligner/aligner.cpp#L71 points_src[2] = keypoints[46]; // This should probably be keypoints[54], assuming this represent nose and 106 keypoint correspond as per following https://arxiv.org/pdf/1905.03469.pdf

MirrorYuChen commented 4 years ago

其实都是可以的，之前那个有bug，所有revert了，关键点这里，我有时间再确认一下~

kafan1986 commented 4 years ago

@MirrorYuChen https://github.com/MirrorYuChen/mnn_example/blob/206bdcf67f24ebcf2d3675ca39287ed08f65541a/src/face/test_face.cpp#L23 I still not sure why sourceFormat at below line is RGBA when you are reading image (img_src in above line) as BGR Mat. https://github.com/MirrorYuChen/mnn_example/blob/d95563833ee9dec8773485464e003c604aea83f2/src/face/landmarker/zqlandmarker/zqlandmarker.cpp#L45

MirrorYuChen commented 4 years ago

其实都可以，你只有保证图像处理输入格式跟你的当前图片格式一致就行了，没啥好纠结的，具体内部会进行转换。

MirrorYuChen commented 4 years ago

等我有时间会再统一一次接口，最近真心忙，没时间。

MirrorYuChen commented 4 years ago

老哥有时间可以帮忙搞个android的项目吗？

MirrorYuChen commented 4 years ago

感觉C++还是差点意思。

kafan1986 commented 4 years ago

@MirrorYuChen I am also very bust with my work. But If I get any time in future, I could help you with android project.

MirrorYuChen commented 4 years ago

ok，多谢啦~