MobileNativeFoundation / rules_xcodeproj

Bazel rules for generating Xcode projects.
MIT License
521 stars 83 forks source link

Feature Request: Support for multiple `pre_build` & `post_build` run scripts #2109

Open sanju-naik opened 1 year ago

sanju-naik commented 1 year ago

Problem

At present pre_build & post_build run scripts take a single script each. This means If I want to run multiple post_build run scripts then I need to combine them in a single script and pass that to post_build argument, this works fine but this limits us from providing Inputs & Outputs to these Individual run scripts.

What I am trying to do

We have a script to copy some files to the generated app bundle, running that each time is costly hence I was thinking to add it as a separate run script and specify Inputs/Outputs.

Feature Request

Instead of a single script, accept an array of scripts in pre_build & post_build and also provide an option to specify scripts Inputs & Outputs.

P.S This feature also depends on issue/feature raised here - https://github.com/MobileNativeFoundation/rules_xcodeproj/issues/2108

brentleyjones commented 1 year ago

We have a script to copy some files to the generated app bundle, running that each time is costly hence I was thinking to add it as a separate run script and specify Inputs/Outputs.

Can you instead use ipa_post_processor?

sanju-naik commented 1 year ago

I tried this, Seems likeipa_post_processor repackages IPA each time run it, I noticed our Processing and Signing step takes ~15 seconds with ipa_post_processor, and without it, it just takes 5-6 seconds for the simulator builds.

This means ipa_post_processor is adding 10 seconds, on each build - which is costly for incremental builds.