Remove `DEPLOYMENT_LOCATION` hack for BwB mode

MobileNativeFoundation / rules_xcodeproj

Bazel rules for generating Xcode projects.

MIT License

527 stars 86 forks source link

Remove `DEPLOYMENT_LOCATION` hack for BwB mode #2790

Closed brentleyjones closed 10 months ago

brentleyjones commented 10 months ago

Introduced in 2fee67adb287f3ea40b815cf2f078276e5e9a479, this is non longer needed after e600086cde98ff0f0736d41a3a3c26833fdd6b25 and possibly as early as after c17968b8425f62af5cdbe5cfe46c5b96d7ad5a3d.

erikkerber commented 10 months ago

Launched to device on Slack

brentleyjones commented 10 months ago

For extra safety, can y'all check that the DYLD_LIBRARY_PATH env variable is of a sane length?

erikkerber commented 10 months ago

Is this what you're looking for?

CleanShot 2023-12-15 at 11 19 31@2x

erikkerber commented 10 months ago

I guess on sim it's a little spicier

CleanShot 2023-12-15 at 11 21 34@2x

brentleyjones commented 10 months ago

The sim one. Looks like it gets cut off, but doesn't seem to include much more, right?

erikkerber commented 10 months ago

Fixed

CleanShot 2023-12-15 at 11 27 41@2x