Closed polac24 closed 9 months ago
46f7a1f47c02e8bec3398913c5d018dd3cc71da5 fixed this for the compile params. Ideally we can find a way to do the same here. The args()
that we use should already turn into params files.
@brentleyjones, thanks for referencing. I tried different features to force param files mode in linking, without success (I tested archive_param_file
, linker_param_file,
supports_param_files`). Let me know, if you know any other ways to workaround that.
If there is nothing available yet, can we workaround this issue with this PR?
Those features would adjust how the normal linking happens. The actions already use a params file though if they don't themselves run into this issue, so instead we are probably dealing with a native rule -> starlark thing. Let me dig in more to see if there is something else we can flip before going this route.
Yep, looks like this will always be broken the way it is until the rules are Starlarkified: https://github.com/bazelbuild/bazel/blob/48892ae099581d4c9ad9bab785add2c0bb17e6be/src/main/java/com/google/devtools/build/lib/rules/cpp/CppLinkAction.java#L228-L242.
I'm fine with something like this change. I'll approve the PR to get it running on CI.
I assume you've tested this with SwiftUI previews? Also examples/integration
?
@brentleyjones, sorry for a late response: yes, I tested SwiftUI preview in examples/integrations
- works fine.
Let me know if I should update something - from what I see, errors in Test - Bazel HEAD
is not introduced in this PR (saw failing on other PRs too).
Correct, those you can ignore.
Just need another approval.
Rehash of https://github.com/MobileNativeFoundation/rules_xcodeproj/pull/1862 for
incremental_link_params_processor.py
Problem
In a step for cache population for a massive application we get "Argument list too long" also from
incremental_link_params_processor
. (command:bazel run //:name.xcodeproj -- --generator_output_groups=all_targets build
)