MobileNativeFoundation / rules_xcodeproj

Bazel rules for generating Xcode projects.
MIT License
514 stars 81 forks source link

Add support for visionOS #2922

Closed chriscraws closed 5 months ago

chriscraws commented 5 months ago

Resolves #2352.

Some notes: apple is a little inconsistent with "visionos" vs "xros" but this worked for generating a test project for myself.

brentleyjones commented 5 months ago

You'll need to sign-off on the commit(s) to pass the DCO check. I recommend squashing all of these existing ones into a single commit for that.

chriscraws commented 5 months ago

You'll need to sign-off on the commit(s) to pass the DCO check. I recommend squashing all of these existing ones into a single commit for that.

Done, also realized I hadn't updated the transition code, so there are a few more changes - see

xcodeproj/internal/fixtures.bzl xcodeproj/internal/xcodeproj_macro.bzl xcodeproj/internal/xcodeproj_runner.bzl xcodeproj/internal/xcodeproj_transitions.bzl

brentleyjones commented 5 months ago

Seems like we need to use minimum_os_version instead of visionos_minimum_os.

chriscraws commented 5 months ago

Seems like we need to use minimum_os_version instead of visionos_minimum_os.

updated

brentleyjones commented 5 months ago

I'm looking into the CI failures

chriscraws commented 5 months ago

Seems like we need to use minimum_os_version instead of visionos_minimum_os.

updated

I'm looking into the CI failures

Fixed a couple issues - I do have a question though about the "minimum_os_version", I'm not familiar with how the fixtures are used but it seems like it's a bit blunt to set that value to 1.0 for generating the fixtures generally. Does it make sense to include it at all?

brentleyjones commented 5 months ago

It makes sense, because soon once 1.1 is available and the default, we want the fixtures to set it to 1.0.

brentleyjones commented 5 months ago

Thanks @chriscraws!

chriscraws commented 5 months ago

It makes sense, because soon once 1.1 is available and the default, we want the fixtures to set it to 1.0.

I see - just seems like that flag would apply to more than visionOS, but the others have coverage over everything else so I'm sure it's fine. Thank you for reviewing and helping me through this!