search

MobileNativeFoundation / rules_xcodeproj

Bazel rules for generating Xcode projects.
MIT License
514 stars 81 forks source link

Remove `TARGET_DEVICE_PLATFORM_NAME` matching from `Info.plist` touching #2936

Closed sebastianv1 closed 5 months ago

sebastianv1 commented 5 months ago

It appears that the TARGET_DEVICE_PLATFORM_NAME check didn't account for iphonesimulator platform name which was causing unit tests running on a test host to not reflect changes made in source code.

brentleyjones commented 5 months ago

Hmm, this was specifically set to that because the change was only needed to fix a device deployment issue. Are you saying that the same issue exists on the simulator?

brentleyjones commented 5 months ago

Does this issue also happen for tvOS? Maybe we need to remove the TARGET_DEVICE_PLATFORM_NAME check all together?

sebastianv1 commented 5 months ago

@brentleyjones Thats correct; it appears to happen on simulator as well. Devs have been reporting that source code changes aren’t reflected in test host target apps.

sebastianv1 commented 5 months ago

Does this issue also happen for tvOS? Maybe we need to remove the TARGET_DEVICE_PLATFORM_NAME check all together?

Haven't tried with tvOS, but logically it makes sense to apply to all platforms? I can add that as a part of this change if you'd like.

brentleyjones commented 5 months ago

Yes please. Also you need to sign-off on your git commit to pass the DCO check.