Closed andre-alves closed 5 months ago
Thanks for this. I'll consider this and another possible change (to fix an incremental install issue).
I just noticed while testing in my project that this diff is not 100% respecting focus settings. I'm trying to respect focused_targets
and unfocused_targerts
because we should only add to direct_dependencies when the extension target has a target in Xcode.
unfocused_targets
looks good;focused_targets
looks good;focused_targets
without also passing the extension fails:ERROR: Internal precondition failure:
external/rules_xcodeproj/tools/generators/pbxtargetdependencies/src/Generator/ConsolidateTargets.swift:145: Target "@//iFood:iFoodApp ios-sim_arm64-min14.0-applebin_ios-ios_sim_arm64-dbg-ST-be4f50282876" dependency on "@//iFood/WidgetExtension:WidgetExtension ios-sim_arm64-min14.0-applebin_ios-ios_sim_arm64-dbg-ST-be4f50282876" not found in `targetIDMapping`
I was expecting focused_extension_infos
to have extensions filtered out in all cases, will need to investigate more.
Thanks Brentley!
----- EDIT -----
Updated to use extensions_info
+ focused_labels
filter, fixed the issue above.
Fixed in https://github.com/MobileNativeFoundation/rules_xcodeproj/pull/3005 Closed.
Fix #2997.