Update rules_ios to 4.4.0 for Bazel 7 support

MobileNativeFoundation / rules_xcodeproj

Bazel rules for generating Xcode projects.

MIT License

502 stars 76 forks source link

Update rules_ios to 4.4.0 for Bazel 7 support #3018

Closed luispadron closed 2 months ago

luispadron commented 2 months ago

Updates to latest rules_ios which should support Bazel 7

brentleyjones commented 2 months ago

This as well: https://github.com/MobileNativeFoundation/rules_xcodeproj/blob/d9462c9176f77fb56e4b80661a8627ca1be0a92d/test/update_all_fixtures.sh#L13-L17

luispadron commented 2 months ago

ah thats the issue, ill get that updated

luispadron commented 2 months ago

Updated, i removed HEAD tests on rules_ios example for now as we have some to_json issues to fix it seems in rules_ios for Bazel 8+

luispadron commented 2 months ago

@brentleyjones thoughts on how to fix this diff?

--- a/examples/rules_ios/test/fixtures/generated/xcodeproj_bwb/defs.bzl
+++ b/examples/rules_ios/test/fixtures/generated/xcodeproj_bwb/defs.bzl
@@ -2,19 +2,19 @@
 # buildifier: disable=bzl-visibility
 load(
-    "@@rules_xcodeproj~//xcodeproj/internal:xcodeproj_factory.bzl",
+    "@@rules_xcodeproj~override//xcodeproj/internal:xcodeproj_factory.bzl",
     "xcodeproj_factory",
 )

brentleyjones commented 2 months ago

Need to change pre-7 CI to only generate fixtures, not validate them. The format changed too much in 7.