search

MobileNativeFoundation / rules_xcodeproj

Bazel rules for generating Xcode projects.
MIT License
514 stars 81 forks source link

Co-locate generated files #3049

Closed brentleyjones closed 3 weeks ago

brentleyjones commented 1 month ago

Resolves #3037.

erikkerber commented 1 month ago

This fixes those "top-level" generated folders from our internal upstream project, and looks pretty good.

We have enough configs with sim+device times 3 product variants that there are 6 generated folders per library, so it's not a silver arrow for making things drop-dead-easy for Apple devs not fluent in Bazel, but it's also a big improvement over what we had previously.

sebastianv1 commented 1 month ago

What if we added an option to map a configuration name to something more idiomatic/familiar? ios_arm64-dbg-ios-arm64-min15.0-applebin_ios-ST-a79286d91b1b: iOS 15 Device Build. It's manual & brittle as configurations change over time but is pretty flexible in naming?

brentleyjones commented 1 month ago

We might be able to smartly translate those, since we know the platform, minOS, and arch for any given config by virtue of targets that have that config. So these could be named similar to how we do target disambiguation 🤔. That would be a followup PR though.

brentleyjones commented 3 weeks ago

@erikkerber @sebastianv1 Can you approve if works for you locally?