MobleyLab / FreeSolv

Experimental and calculated small molecule hydration free energies
http://www.escholarship.org/uc/item/6sd403pz
106 stars 53 forks source link

Changes from adding automated parameter conversion #36

Closed mrshirts closed 7 years ago

mrshirts commented 7 years ago
mrshirts commented 7 years ago

One thing to be resolved: there are now two sets of gromacs files in vacuum -- the original ones that were in topgro.tar.gz (now in gromacs_original.tar.gz), and new ones in gromacs.tar.gz that were generated in the automated process conversion. The new ones DO have full energy validation of their conversion, but are not the files that were used in the free energy calculations. So I don't know what the best call is for distributing/labeling those two sets of files.

davidlmobley commented 7 years ago

@mrshirts - relating to the two sets of GROMACS files, what is the EXACT procedure you used to generate these? (ParmEd version, for example?) Have you diffed any of them against the original vacuum files? Naively, I would hope that we generated them with the same or equivalent ParmEd versions so they would actually be identical, but if they are not, then we will have to retain both sets and label them separately (and I'll need to explain exactly where yours came from/why they are included).

mrshirts commented 7 years ago

I can set up an automated energy check on the two sets (maybe by late tonight, not earlier). In terms of where they came from, that's documented in the instructions; InterMol calling ParmEd and doing amber ==> GROMACS. So they should be the same energies, but there are still some bugs in ParmEd.

davidlmobley commented 7 years ago

@mrshirts - which ParmEd version? Bugs: Do you mean there are bugs relating to AMBER-> GROMACS? I have not been aware of any but if you are, that would be important to know.

mrshirts commented 7 years ago

2.73. I'm saying with 650 files, unless you ran the energies for both of them and checked, there could be bugs. We found a couple in Amber->Charmm conversion when running FreeSolv. (actually, another was introduced between 2.73 and master that still needs to be resolved). If you already checked all 650 energies amber->gromacs, then there probably aren't any differences.

mrshirts commented 7 years ago

Here's some output of a comparison -- attaching the tools so you can query things a bit more. New .gro files are used for all comparisons, but different .top files.

FreeSolvCompare.zip Upshot:

davidlmobley commented 7 years ago

OK, thanks, @mrshirts . So I think the upshot of comparing your GROMACS topologies to ours (which, for the record, as per our discussion elsewhere, were generated from AMBER via acpype prior to our migration to ParmEd) is that the energies are rather similar except for the differences one would expect from Coulomb interactions due to charges which are rounded differently. So I will make sure to clearly note the differences between these two sets of files in the README.md documents.

I'm going to go ahead and merge this, and then go through and see if any minor cleanup is needed and bring it in in a separate PR.