MohammedRashad / Crypto-Copy-Trader

A copy trading tool for cryptocurrencies - Binance Exchange
Apache License 2.0
202 stars 86 forks source link

Slaves not Opening trades when using 100% of balance #11

Closed djcrawleravp closed 4 years ago

djcrawleravp commented 4 years ago

Using Stop Limit with 100% balance

Stop limit100%

Using buy Limit with 100% balance

Limit error 100%
MohammedRashad commented 4 years ago

what is 100% balance?

djcrawleravp commented 4 years ago

Hi Mohammed,

Its When the master account uses all of its funds to do a trade

Sent from my iPhone

On May 25, 2020, at 09:14, Mohamed Rashad notifications@github.com wrote:

 what is 100% balance?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

MohammedRashad commented 4 years ago

Please pull the latest version, we fixed this bug.

Let me know if fixed.

djcrawleravp commented 4 years ago

I did a new pull yesterday,

I’ll try again later today

Thanks for the help!

Sent from my iPhone

On May 25, 2020, at 09:39, Mohamed Rashad notifications@github.com wrote:

 Please pull the latest version, we fixed this bug.

Let me know if fixed.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

djcrawleravp commented 4 years ago

I ran I new test, the issue still happening

mokolotron commented 4 years ago

I really found several bugs, one of them is that the system opens a order not from the entire available balance, but also from the blocked one (that is, which one is in orders). This will cause a "influenced of balance" error if you have other orders open.      Also, an error can be detected by manipulations during the program's operation with the balance of those coins that are specified in config.csv in the first line.      Now I am working on global refactoring and web sockets so I can fix these problems in the next pull-quest but it can take about a week

MohammedRashad commented 4 years ago

can you break them to smaller parts? like multiple pull requests so I can review and edit if needed?

djcrawleravp commented 4 years ago

Solved!