Closed YourMJK closed 4 months ago
Seems fine to me, I'll test it a bit tomorrow and let you know :)
@MonoS Did you come around to testing this? Let me know if you want me to change something.
Did you come around to testing this?
Yeah, i've put some comment in your code, i can see them in this PR before your latest comment.
Oh, don't know why but I can't see those unfortunately ¯\(ツ)/¯
Oh, don't know why but I can't see those unfortunately ¯_(ツ)_/¯
That's probably because I don't know how to use github :)
Anyway:
--trace
doesn't have the check for its option without dashWindow frame position
and Window frame size
In any case I can see the code review from this link https://github.com/MonoS/SupMover/pull/18/files/8968b7ce51e5384b9684d1a867d82b3ef87393cb And looks like this
That's probably because I don't know how to use github :)
That's fine, I'm not familiar with code review on GitHub either :) But I think you need to click on "Review changes" and then "Submit review" for me to see it. Those comments are still pending (see your screenshot).
- The new --trace doesn't have the check for its option without dash
That was on purpose since it's part of the old syntax and thus doesn't need to be backwards compatible. But for consistency I can of course add that check as well.
Agreed on the other two points!
Should be fixed now
Merged, thank you :)
See discussion: https://github.com/MonoS/SupMover/pull/17#issuecomment-1924849735
--trace
option for printing structure and contents of segments--trace
)