Fix linux compilation and add missing includes and prefixes

MonoS / SupMover

SupMover - Shift timings and Screen Area of PGS/Sup subtitle

GNU Affero General Public License v3.0

41 stars 4 forks source link

Fix linux compilation and add missing includes and prefixes #7

Closed hannesbraun closed 1 year ago

hannesbraun commented 1 year ago

Some includes were missing that would cause the compilation to fail on Linux. While I was at it, I also fixed a few other issues:

We're now using nullptr instead of NULL as that is the recommended way to use null pointers in C++
A lot of places were missing the std:: prefix. To circumvent any possible future issues, I tried to add it to all the places where I think it was missing.
We're using <cmath> (the C++ version) instead of <math.h> (the C version).

MonoS commented 1 year ago

Thank you for your commits, i'll merge them right now. Could i also ask you to attach to this pull request a linux binary, if that's even a thing, so that i can add it to the release section?

hannesbraun commented 1 year ago

Could i also ask you to attach to this pull request a linux binary, if that's even a thing, so that i can add it to the release section?

Sure, I can do that. I also included a binary for ARM Linux and Intel Macs, in case you'd like to include that.

supmover-linux-aarch64.zip supmover-linux-amd64.zip supmover-macos-amd64.zip

I don't know how portable these are though as they are linked dynamically. Not sure if there are going to be version conflicts on other people's machines.

On that note: I can also set up a GitHub Actions workflow for macOS and Linux quickly, if you'd like to have that. That would ensure that Linux and macOS compatibility doesn't break without notice and they could even emit a binary.

MonoS commented 1 year ago

Yeah, if you want sure, i was being mocked (jokingly) by a friend that i didn't had those setup, but I don't know how to do it :)