Monviech / os-caddy-plugin

Caddy Plugin with GUI for OPNsense
Other
38 stars 0 forks source link

Typos to fix in next version #73

Closed Monviech closed 8 months ago

Monviech commented 8 months ago

https://caddy.community/t/with-caddy-x509-certificate-relies-on-legacy-common-name-field-use-sans-instead/18913

The common name (CN) isn't valid to use in certificates. (SAN) Subject Alternative Name has to be present in a certificate.

The help text specifies CN instead of SAN. This has to be fixed in the next version.

https://github.com/Monviech/os-caddy-plugin/blob/ffe3ce5ab0c137afe73aedafb141fc868554f2cb/usr/plugins/devel/caddy/src/opnsense/mvc/app/controllers/Pischem/Caddy/forms/dialogHandle.xml#L68

Monviech commented 8 months ago

Another Typo, it's HTTP over TLS.

https://github.com/Monviech/os-caddy-plugin/blob/4c0cc60323c8cb98368ab1221e5a33b7a8a185d5/usr/plugins/devel/caddy/src/opnsense/mvc/app/controllers/Pischem/Caddy/forms/dialogHandle.xml#L54