Add Browser selection support

Moonshine-IDE / Super.Human.Installer

Super.Human.Installer helps you install the latest and greatest HCL Domino technologies easily.

https://superhumaninstaller.com/

Other

2 stars 0 forks source link

Add Browser selection support #81

Closed piotrzarzycki21 closed 1 year ago

piotrzarzycki21 commented 1 year ago

We need to be able to pickup default browser which will be opened once server creation has been finished.

piotrzarzycki21 commented 1 year ago

We have decided to have that support under Settings

piotrzarzycki21 commented 1 year ago

I have pushed an update where:

Open selected browser on Windows should work now
we can now change default browser using list - without need of opening edit

New development build is available - it need to be installed manually -> https://github.com/Moonshine-IDE/Super.Human.Installer/releases/tag/0.8.18-dev

JoelProminic commented 1 year ago

Some cosmetic issues from today's discussion:

The error message has bad contrast here.

The user should not be able to make an unconfigured browser the default:

piotrzarzycki21 commented 1 year ago

@JoelProminic I have changed interface to have browsers settings in setting page - It's less confusing for the user.

All links in application now opens in selected browser including welcome page once server finish start Newest build is here: https://github.com/Moonshine-IDE/Super.Human.Installer/releases/tag/0.8.18-dev

I would like to release that version after our tomorrow's meeting.

JoelProminic commented 1 year ago

The update looks good. I think moving the Browser list to be directly in Settings makes sense:

One minor issue I noticed when testing links is that the Brave download link actually opens the Firefox download page. We should do a similar test on Windows before the release

JoelProminic commented 1 year ago

I did a quick test on Windows and confirmed that the download URLs looked correct. I was testing on a Vagrant VM, so I wasn't able to test the URL trigger after the VM was created.

Other known remaining issues:

Need to clarify that Firefox is the recommended browser.
Can't edit browser paths. I think @piotrzarzycki21 was planning this for the next release.

piotrzarzycki21 commented 1 year ago

Thanks for testing! I see that you still doesn't have Opera on this list. I'm not sure why it's happening at your machine. I remember we were cleaning your browser part of configuration and still it did not help. I will think about it tomorrow morning more.

JoelProminic commented 1 year ago

Ah, I did wonder about that when I saw Opera on Windows.

On the note of Opera, I did some tests with installing each of the browsers, and I found that the Windows path for Opera did not work for me:

The paths seem to match up, except for ${userName}. It seems this insertion parameter didn't work.

I checked for a Program Files entry for Opera, but I don't see it either.

On a side note, this reminded me of the contrast problems for the "%browser% not detected" messages. My setup is making the problem worse, but I think the red text needs to be a little brighter, or it needs a (dark gray?) background.

piotrzarzycki21 commented 1 year ago

My setup is making the problem worse, but I think the red text needs to be a little brighter, or it needs a (dark gray?) background.

I have made text brighter and more visible.

piotrzarzycki21 commented 1 year ago

The paths seem to match up, except for ${userName}. It seems this insertion parameter didn't work.

I have fixed this issue, but you will have to clear up your Browsers settings manually. I think I will add in the next release some kind of button which allows reset our settings to default one.

piotrzarzycki21 commented 1 year ago

Browsers selection has been added. Raise new issue in case of any problems.