search

Morisset / PyNeb_devel

PyNeb development repository
Other
42 stars 10 forks source link

pn.RecAtom('H', 1, case='A') does not produce case A values. #19

Closed Knusper closed 3 years ago

Knusper commented 3 years ago

Hi,

thanks for pyneb. The following

import pyneb as pn
hi_a = pn.RecAtom('H', 1, case='A')
hi_b = pn.RecAtom('H', 1, case='B')
hb_a = hi_a.getEmissivity(1e4,10, label='4_2')
hb_b = hi_b.getEmissivity(1e4,10, label='4_2')
print(hb_a, hb_b)

yields 1.235e-25 1.235e-25

However,

pn.atomicData.setDataFile('h_i_rec_SH95-caseA.fits', 'H1','rec')
hi_a =  pn.RecAtom('H', 1)
print(hi_a.getEmissivity(1e4,10, label='4_2'))

yields 8.245e-26.

But the init signature is:

 pn.RecAtom(elem=None, spec=None, atom=None, case='B', extrapolate=False)

So the case= paraemter is not yet implemented?

Best regards, Christian

Morisset commented 3 years ago

Hi Christian, The case keyword actually works when the datafile includes both cases, like the Pequignot et al 1991 fits for example. In the case of HI and HeII, the datafiles are quite big and have been separated in the both cases. In this case you are right that the way to change the case is not by the keyword, but rather by changing the atomic data file, as you did. Note that you can use the h_i_rec_SH95-caseA.fits or the h_i_rec_SH95-caseA.hdf5 file, both are accepted. I will copy this issue and my answer to the discussion group, it may help other users.

Knusper commented 3 years ago

OK, please consider documenting this in the docstring, as it took me a long time to figure out that this was actually the source of an error in my calculations...