Closed calummackervoy closed 3 years ago
Sorry, been meaning to review this - I'll take a look this evening, is that okay? :smile:
Yeah no problem at all! No need to apologise, from my point of view at this stage of the project I'm thinking "it's great if I can get a code review, but if I can't it's no problem" - because I appreciate that I'm writing a lot of code so I think some of it will have to be merged without review
Thanks, made these changes :)
@MattTennison sorry about the massive MR :grimacing: this MR shouldn't impact the front-end
Partial implementation of #3. There's going to be lots more to do for that so I thought I should merge the part that's working before I move onto the next thing
AbstractFileStorageWrapper
,DatasetItem
andDatasetCollection
provide classes for getting file storage paths and URIs.MUDApplication
still stores the root diretories of these things and they're still not configurable in theweb.xml
(another issue)DataController
endpoint. Effectively I give this any path (it's the default) and it'll get me that dataset (e.g./mud/world/
or/mud/actions/tasks/mytask/#myResource
. At the moment if that dataset doesn't exist it'll create it, it'd be better if it was 404201
with the location of your datasetendState
consequences can be made (updating the world state and my character's state)ResourceItem
,Patch
andTask
classes manage the creation and TDB commit of resources