search

Multi-User-Domain / mud-jena

0 stars 0 forks source link

Return Turtle Content #7

Closed MattTennison closed 3 years ago

MattTennison commented 3 years ago

What?

This PR will change the /content endpoint to produce turtle content.

Why?

Related Issue with reasonings: https://github.com/Multi-User-Domain/mud-jena/issues/1

calummackervoy commented 3 years ago

I guess there's a vocabulary PR to open and some React changes ... interesting question how to do the second part of that... I guess we can just fetch the content from the mudcontent:sees property for the MR ? Interesting because we'll need to start implementing a system responsible for reading returned content and deciding what to display from it, when to look for more content etc

MattTennison commented 3 years ago

I guess there's a vocabulary PR to open and some React changes ... interesting question how to do the second part of that... I guess we can just fetch the content from the mudcontent:sees property for the MR ? Interesting because we'll need to start implementing a system responsible for reading returned content and deciding what to display from it, when to look for more content etc

I've made changes to the vocab repo, but had difficulty pushing them to the MUD version (permissions issues, not sure why). I forked it and made a PR here: https://github.com/Multi-User-Domain/vocab/pull/2

I haven't made any changes to the React code, I'd be up for making those but it might be a job for next weekend. If that's okay, I'll raise an issue and assign it to myself, if not - happy to review a PR from you 😄

calummackervoy commented 3 years ago

OK nice one thanks! Of course no worries, thanks for doing this :) I'll take on the React code, I have a clear idea of what to do in my mind so piece of cake :)

calummackervoy commented 3 years ago

If https://github.com/Multi-User-Domain/mud-react/pull/15 is alright then we're ready to merge :)