search

MusicConnectionMachine / RelationshipsG4

In this repository we will try to build and determine relationships between composers
GNU Affero General Public License v3.0
0 stars 3 forks source link

Setting up continuous integration #40

Closed simonzachau closed 7 years ago

simonzachau commented 7 years ago

My current idea: Github --(1)--> Travis --(2)--> Docker --(3)--> Azure

  1. Works.
  2. What is the best way? Should we do it like mentioned here?
  3. We are experimenting on Azure.
kordianbruck commented 7 years ago

Great, please implement this till the set milestone.

Regarding 2/3: I think @sacdallago said its best to use dockerhub

kordianbruck commented 7 years ago

Checkout (and copy?): https://github.com/MusicConnectionMachine/VisualizationG6/blob/develop/.travis.yml https://github.com/MusicConnectionMachine/VisualizationG6/blob/develop/Dockerfile

sacdallago commented 7 years ago

You can still user Travis to run tests + docker (hub's automatic build) to run the build, then you basically two testing mechanisms.

For deployment, you can directly do docker hub -> Azure via the Linux App Service, it should also directly fetch new builds from docker hub, but this I've never had time to test

simonzachau commented 7 years ago

@kordianbruck For step 2 (Travis->Docker) I followed the example of the .travis.yml file from @MusicConnectionMachine/group-6, however, Travis always tells me Error response from daemon: Get https://registry-1.docker.io/v2/: unauthorized: incorrect username or password even though the login on my local machine works fine. @sacdallago For step 3 (Docker->Azure) I know that it works, we've tested that.

kordianbruck commented 7 years ago

Did you set $DOCKER_USERNAME and the password in the environment variables?

simonzachau commented 7 years ago

@kordianbruck yes

simonzachau commented 7 years ago

I even tried it with environment variables in the .travis.yml instead of the settings pane now. But it refuses to authorize.

simonzachau commented 7 years ago

Step 2 (Travis->Docker) is working now! My Password contained spaces which needed to be escaped in the environment variables. Thanks @Henni for taking a look at it together.

Step 3 (Docker->Azure) is already tested with another image. So the rest of the CI work will be done on #34 . Therefore, I'll close this issue now.

kordianbruck commented 7 years ago

Who has spaces in his password - really? :dagger:

Sandr0x00 commented 7 years ago

Here! 😋

simonzachau commented 7 years ago

well... when your password is more of a passphrase then you do ;-)

simonzachau commented 7 years ago

Btw. the built docker is sent to musicconnectionmachine/relationshipsg4 now.