Closed carl-drews closed 1 month ago
Just noticed the tests are failing - is this something unrelated to this PR?
I don't know why the checks are failing; it looks like the docker-compose command is not found.
TS1 and CHAPMAN run to completion and produce output. FLOWTUBE does not run because of differences among FLOW* macros. See Slack. FULL_GAS_PHASE does not run because of "description". See Slack.
Ready for another round of reviews after addressing requests. Note that TS1 will not run without this python change in music_box.py on about line 721. The addresses a gap in the ordered sequencing:
rate_constants = {}
for rate in curr_conditions.reaction_rates:
if (rate.reaction.reaction_type == "PHOTOLYSIS"):
key = "PHOTO." + rate.reaction.name
elif (rate.reaction.reaction_type == "LOSS"):
key = "LOSS." + rate.reaction.name
elif (rate.reaction.reaction_type == "EMISSION"):
key = "EMIS." + rate.reaction.name
rate_constants[key] = rate.rate
**ordered_rate_constants = (len(rate_constants.keys()) + 1) * [0.0] # bogus + 1**
The test failure is nothing to do with the code added here, and something with the action. I fixed it in #422
Formatted with indent = 2 spaces.
TS1 is ready for further development (restore initial conditions).
Added the following files to examples: Directory of C:\2024\MusicBox\music-box-interactive-api\interactive\api\static\examples\TS1
08/01/2024 05:19 PM
Use Docker to verify that the JSON files are retrievable, for example: http://localhost:8000/api/load-example?example=TS1