NCIOCPL / drug-dictionary-app

NCI Drug Dictionary Application
2 stars 0 forks source link

Change out node-sass for sass #127

Closed sarinapadilla closed 1 year ago

sarinapadilla commented 1 year ago

Issue description

ESTIMATE 1

node-sass has been deprecated for almost 2 years now. sass is the correct module to use. Additionally, the version of node-sass that this repository uses, and many of the others, does not work well with newer node/npm combinations. (Basically Node 12 and NPM 6 works -- anything outside of that an YMMV).

So... is it just updating? Based on experience with CGDP, NO. Some things to check:

  1. sass-loader might need to be bumped.
  2. Your sass may suck and things that should have failed will fail now. It could also be one of the situations where sass does not do something node-sass did and that is the way they are going to keep it.

The following is what we did on the platform and react-app-playground for both bumping Node, Updating loaders, and moving from node-sass to sass. May your experience go smoother -- definitely a lot less SASS to go through, and newer to boot.