(#76) Fixes dropdown position based on screen

NCIOCPL / drug-dictionary-app

NCI Drug Dictionary Application

2 stars 0 forks source link

(#76) Fixes dropdown position based on screen #81

Closed karlikpj closed 3 years ago

karlikpj commented 3 years ago

Closes ( #78 )

Add check for screen position and dropdown items for placement.

karlikpj commented 3 years ago

to test - go to: https://react-app-dev.cancer.gov/drug-dictionary-app/pr-81/def/b-raf-vegfr-2-inhibitor-raf265 scroll to the bottom and test searches for TAP (4 results) and TRE(10 results) and observe placement of dropdown. It should never go off the page (below the fold) or cause extra scrollbards.

kate-mashkina commented 3 years ago

The vertical scroll still appears after the following steps: 1) Go to any definition page such as https://react-app-dev.cancer.gov/drug-dictionary-app/pr-81/def/a-101-topical-solution 2) Scroll to the bottom of a page 3) type 'per' - see the menu flip (which is good) 4) click anywhere outside of a box (to remove focus from dropdown) 5) click on autosuggest field again - the dropdown is back at the bottom and the scroll is there

Screen Shot 2020-11-05 at 1 08 16 PM

mworrest commented 3 years ago

Looks good to @blilianyu and me from a design perspective.