NHMDenmark / Mass-Digitizer

Common repo for the DaSSCo team
Apache License 2.0
1 stars 0 forks source link

Multiobject warning #274

Closed PipBrewer closed 5 months ago

PipBrewer commented 1 year ago

Christian Lange (22/02/2023) suggested that when doing, multispecimen objects, that have a pop up that asks you to confirm that it is a multispecimen object when try to save record. That behaviour will continue until uncheck multiobject checkbox. The reason for this request, is he (and there was agreement from others) that it would be very easy to overlook the fact that you had forgotten to uncheck the box. This would be harder and more time consuming to fix later. There are also not enough multiobject sheets that the warning would be too troublesome.

HOWEVER, you are more likely to encounter MANY multiobject specimens in entomology and this pop up box would be very annoying?

For discussion with development team - ideas.

Please don't implement before discussion, so a decision can be made.

FedorSteeman commented 1 year ago

Instead of a popup, it could also be a label (with red letters perhaps) in close proximity to the save button. In any case seems easy to implement. Let's discuss.

jlegind commented 1 year ago

I like Fedor's suggestion that there could be a loud and obnoxious label or popup stating that --you are about to save a multi-object record--

FedorSteeman commented 1 year ago

Or perhaps a popup Clippy wagging its little end: image

PipBrewer commented 1 year ago

Bhupjit has alternative suggestions which aren't as annoying than clicking on pop ups

jlegind commented 1 year ago

Effort level: 'Easy'

jlegind commented 11 months ago

We have some additional ideas that are not pop-up windows/prompts. It could be:

jlegind commented 11 months ago

Had a meeting with Chelsea and we came to the conclusion that a sticker or warning sign at the bottom right corner of the app would be very striking. The optimal solution would to have the warning label AND highlighting the Container ID field.

jlegind commented 10 months ago

I created this warning label simple_warning_small

It can be resized of course.
My concern is that the inputted image might push the other elements and ruin the alignment and symmetry of the app appearance. Here is a tutorial: https://www.tutorialspoint.com/pysimplegui/pysimplegui_image_element.htm

jlegind commented 10 months ago

Christian Lange has approved the suggestion from email conversation 06-09-2023 multi-specimen_warning.pdf

FedorSteeman commented 9 months ago

Christian Lange has approved the suggestion from email conversation 06-09-2023 multi-specimen_warning.pdf

This e-mail conversation is about the specimen condition and not the multi-specimen warning.

Is the requirement to be according to https://github.com/NHMDenmark/Mass-Digitizer/issues/274#issuecomment-1711482993 ?

FedorSteeman commented 9 months ago

Anyways, estimated to take up to a day to implement, though probably a matter of hours.

PipBrewer commented 9 months ago

2 issues here: 1. The suggested text does not take into account both scenarios (mutispecimen and multiobject). 2. It has not been approved by those who requested it (the users and particularly Christian Lange).

Options: We have one message for both scenarios We have a slightly different message for the 2 scenarios.

@chelseagraham can this be raised at the two zoom meetings?

jlegind commented 9 months ago

Christian Lange was contacted regarding a warning label when entering Multi specimen objects or One specimen on multiple objects. Jens Soelberg replied (Christian Lange forwarded the email to him) and he accepted the solution proposed: A warning label appearing when the "multi radio buttons are activated".

Now we need to decide where on the UI the label should appear in the app. We need to decide when the label appears. Is it when the radio button is activated, or is it after the first save with 'multiple' active? multi-specimen_warning_Jens_Soelberg.pdf

chelseagraham commented 9 months ago

I included the proposed solution in meeting notes sent to the Herbarium group and asked for input by 27 October. I will discuss it in my Entomology today. If there is any input, I will register it here.

Once there is a solution, I can send screenshots around to the groups to show them.

FedorSteeman commented 5 months ago

@chelseagraham Was there any input and what solution shall I implement then?

chelseagraham commented 5 months ago

The proposed solution that I presented to the groups in October was the warning label and there was no input. After speaking with Pip, I have created 5 options: WARNING01 WARNING02 WARNING03 WARNING04 WARNING05

chelseagraham commented 5 months ago

@PipBrewer likes WARNING02

I have sent an email to Christian Lange and Jens Soleberg. @Gomismis @nms419 @RebekkaML @AstridBVW @JesperMJensen please register your thoughts preferences here ASAP by 14 February

Gomismis commented 5 months ago

"This record will be linked to the previous record." If I had to choose, I would prefer the first option because it makes the most sense to me. However, the most important factors for me are:

1) That the warning don't pop up and block the app, because when digitizing, we aim to minimize interactions, clicks, and tabs in the app to optimize the digitization rate.

2) It should produce a sound. I believe this is important because 99% of the time, I forget to unclick the MOS button in the app it is caused by not looking up while digitizing (since all other settings remain the same).

nms419 commented 5 months ago

"You are creating a linked record" or "Multi Radio Buttons are Activated" would make sense to me, but as long as the warning label is visually loud I don't think the exact wording matters much.

If the selected multi radio button could be highlighted as well that would be great.

AstridBVW commented 5 months ago

I prefer the second option, "You are creating a linked record". I like the meaning of the first option but I think the text is too long.

I agree with Matilde, it is important that it does not block the flow. And I understand the idea behind adding a sound but I think most of us are digitising while using headphones and listening to either music or audiobooks. So I think the sound will have to be pretty loud for us to be able to hear it.

And yes, could be good to have the selected multi radio button highlighted.

RebekkaML commented 5 months ago

I also prefer "you are creating a linked record".

JesperMJensen commented 5 months ago

I agree with "You are creating a linked record" and also agree with Matildes two points on flow and sound.

FedorSteeman commented 5 months ago

@chelseagraham As soon as there's agreement, please clarify or restate and assign this ticket to me.

chelseagraham commented 5 months ago

@chelseagraham As soon as there's agreement, please clarify or restate and assign this ticket to me.

Will do, @FedorSteeman I am waiting for feedback from the collections managers. Probably after vinterferie :D

FedorSteeman commented 5 months ago

@chelseagraham Got feedback? I have reached this ticket and would like to start implementing soon.

chelseagraham commented 5 months ago

I nudged the collections managers yesterday for feedback. I'll let you know when I get it!

chelseagraham commented 5 months ago

In an email dated 21 Feb, Jens Soelberg conveyed that he thinks numbers 1-3 are fine, but agrees that number 2 is to the point and adequate for our users

FedorSteeman commented 5 months ago

So to sum up: Just a label corresponding to option nr 2 "WARNING! You are creating a linked record". This should become visible whenever an option other than single-specimen object is selected and made invisible when switching back again. I could not gauge a consensus or clear decision on a sound, so will leave that be for now.

Gomismis commented 5 months ago

So to sum up: Just a label corresponding to option nr 2 "WARNING! You are creating a linked record". This should become visible whenever an option other than single-specimen object is selected and made invisible when switching back again. I could not gauge a consensus or clear decision on a sound, so will leave that be for now.

It would be really helpful for some of us if we could have the warning sound included. As I understand it that there's a concern about it not being heard by people with headphones, so I guess it won't bother those who don't want it.