NHMDenmark / Mass-Digitizer

Common repo for the DaSSCo team

Apache License 2.0

1 stars 0 forks source link

Clearing the full taxon name does not erase other taxon data #402

Closed bhsi-snm closed 10 months ago

bhsi-snm commented 11 months ago

Template for issues/tickets in DigiApp

What is the issue ?

If you have taxon names and save some records. 
On deletion of records, the taxon name and scan barcodes in, retains some of the taxon info in the local app 
db specimen table, but not all of the info (see records 47-49 in below screen shot for which the taxon name 
was empty in the UI). Tested for NHMA and NHMD.

Context

If this issue is not resolved, records containing errors might be left in the DB and if imported into Specify would be much harder to identify and remove.

What is the expected acceptable result.

it should clear the db row completely on record deletion

FedorSteeman commented 11 months ago

It does now

jlegind commented 10 months ago

The acceptable behavior: it should clear the db row completely on record deletion has not been implemented as only the taxonomic information is wiped when deleting the taxon name and saving. Currently it is not possible to do a full record deletion through the UI.

FedorSteeman commented 10 months ago

There is some contradiction between the ticket title and description. The issue was taken to be that clearing the taxon input field, should also clear all related taxon data fields, but not the entire record. As Jan stated, it is not possible to delete records. Please note that this has never been a requirement yet to enable the user to delete a record.

bhsi-snm commented 10 months ago

I agree, there is a small but important distinction between deleting the record and clearing it. Is there a way to handle partially empty records in GREL script ?? I agree, deletion is not part of DigiApp functionality, but @PipBrewer, what is the ideal behaviour? <this issue is reflection of your testing working done along with Jan(via the doc that you circulated).

FedorSteeman commented 10 months ago

Clearing the taxon name should only clear taxon-related data and not the entire records.

I doubt this will pose an issue for the PostProc script.

PipBrewer commented 10 months ago

Just spoke to Bhupjit. He was particularly worried about importing data to Specify with little to no information other than barcode. I explained that that is not an uncommon situation in collections.