search

NHMDenmark / Mass-Digitizer

Common repo for the DaSSCo team
Apache License 2.0
1 stars 0 forks source link

Shift tab from Taxon ID field crashes app #412

Closed jlegind closed 11 months ago

jlegind commented 11 months ago

Issue

Under NHMA sign in, the app will crash if the user shift-tabs out of the Taxonomic ID field. This is a disruption to the workflow and might reduce confidence in the Digi App.

Acceptable solution

Tabbing behavior should be fluid and not throw off artifacts.

FedorSteeman commented 11 months ago

The tabbing and shift-tabbing need to be reworked.

FedorSteeman commented 11 months ago

Shift-tabbing with activated taxon number field caused the app to go in an infinite loop constantly switching between setting focus on taxon number field and barcode field. The cause of this bug could not be traced, but the infinite loop is now stopped in its tracks by measuring the amount of time elapsed and breaking when it is shorter that 50 ms.

Another major change that was made with the idea to prevent UI triggers that would the possible cause is getting the form values from events instead of directly from the window. It may need to be tested, however, if all values are still correctly persisted.

FedorSteeman commented 11 months ago

Closed for now, but we may need to revisit to find a lasting fix for this bug.

jlegind commented 11 months ago

elif event == 'inpTaxonName':
# Ensure any tabs are kept from creeping into the taxon name entered if "\t" in keyStrokes: self.setFieldFocus('inpCatalogNumber')

jlegind commented 11 months ago

Shift tab in the App for NHMA taxon ID field sends the focus to Barcode.