NHMDenmark / Mass-Digitizer

Common repo for the DaSSCo team
Apache License 2.0
1 stars 0 forks source link

Change the flow around container types #439

Closed PipBrewer closed 4 months ago

PipBrewer commented 8 months ago

If select SSO, MSO or OSM radio buttons, the focus goes immediately to barcode field. However, this should not be the case when just tabbing past these.

The reason for this is that when first log on to App, you will tab through all fields and will do it one after the other. However, during digitisation, you will rarely change much other than taxonomic name (and occassionally broad geographic region), but will often need to select the radio buttons SSo, MSO and OSM and then continue beeping barcodes.

This was requested by MG on 19/10/2023 (via digitisers issue log). CG to raise with other digitisers, collection managers and curators and ask if this is something they would like implemented (although unlikley to be implemented in the next few months).

Regarding the priority of this, need some more information about frequency this happens.

PipBrewer commented 7 months ago

This was discussed at the monthly digitiser meeting today (23/11/2023). It was agreed that this would be very useful. I also checked through data files and both MSO and MOS specimens are very common and so it makes sense to implement this. One issue remains: when it is the first record of the day, moving the focus directly to the barcode field could be irritating, as you would then need to go back through the fields in between the two. The solution would be to move the containers to just above the barcode field. This was agreed to be really useful anyway. Everyone at the meeting agreed with the request.

Decision: re-organise the UI so the containers are direcly above the barcode field (and below taxonomic name). This may necessitate (if it makes it easier), getting rid of the division between the green and blue areas on the app (which actually don't make sense anymore). container move

chelseagraham commented 5 months ago

I see no problem with moving the container fields to between the taxonomic name and barcode fields. I am checking in with the Digitizers and requested feedback by the end of the day on 7 February. Notes is another field that they need to type in at times and which sometimes may alter the flow through the UI.

RebekkaML commented 5 months ago

I agree that it makes sense to move the container field. I think it would also make it easier to spot when you forget to uncheck it after an MSO / MOS.

JesperMJensen commented 5 months ago

I agree with moving the fields.

AstridBVW commented 5 months ago

I agree with moving the container fields and would also suggest moving the notes field closer to the barcode field.

chelseagraham commented 5 months ago

Based on feedback, it is proposed to move the fields that are not sticky to the same region and keep it colored a brighter, eye catching color as below: Picture1

chelseagraham commented 5 months ago

Just chatted with Pip and am adding these notes about alignment of text and fields as well as placement of future radio buttons for Specimen Obscured and Label Obscured Picture2

chelseagraham commented 5 months ago

@FedorSteeman Here are the proposed changes to the UI

FedorSteeman commented 5 months ago

@PipBrewer @bhsi-snm Looks clear! Please move to ticket to the right place on the board and I will reach there eventually. 🙂

FedorSteeman commented 4 months ago

@chelseagraham What caption should I give the new radiobutton collection "label obscured" & "specimen obscured"?

Or are these to be checkboxes instead?

chelseagraham commented 4 months ago

I think the caption for the radio buttons could just read "Status" or perhaps, "Visibility" @PipBrewer what is your preference?

FedorSteeman commented 4 months ago

@chelseagraham OK, but just so that I understand: Can the status be that either the label is obscured or the specimen? If not mutually exclusive then you should go with checkboxes and not radio buttons.

What do you think of this layout example?

image

P.S.: I noted that the container fields are sticky, even though they're moved to the area now designated as for "non-sticky" fields. Is this inconsistency intended?

RebekkaML commented 4 months ago

Either the label can be obscured, or the specimen, or BOTH, so we need to be able to check off both boxes if necessary.

FedorSteeman commented 4 months ago

Oh I can see this was already mentioned in the ticket dealing with this: https://github.com/NHMDenmark/Mass-Digitizer/issues/445#issuecomment-1943486193

Let me take it there...