search

NHMDenmark / Mass-Digitizer

Common repo for the DaSSCo team
Apache License 2.0
1 stars 0 forks source link

Entering new taxon does not clear taxon number field #441

Closed FedorSteeman closed 5 months ago

FedorSteeman commented 8 months ago

Template for isues/tickets in DigiApp

What is the issue ?

Entering new taxon does not clear taxon number field

Steps to reproduce: 
1. Log on to a collection that uses taxon numbers like NHMA 
2. For a new record enter an existing taxon using the taxon number input field 
3. If need be save the record with a catalog number; the taxon field values will be carried over to the next new record
4. Edit the taxon name input field for the new record and enter an unknown (new) taxon name
5. Choose a family for the new taxon and press the OK button in the popup
6. When done, the taxon number field is not cleared

Why is it needed/relevant ?

The taxon number is associated with taxon that are known and part of the taxon spine for the collection in question. Not clearing this field when entering a new taxon, i.e. one unknown to the taxon spine, makes no sense. The most serious effect of this is that the new taxon will be imported into Specify and thus the taxon spine with the taxon number that actually belongs to another taxon. This would feedback to the app contaminating and undermining the taxon number system.

Estimate level of effort required.

easy

What is the expected acceptable result.

The taxon number input field should be cleared whenever a new taxon is added.

What could be the challenges ?

No challenges foreseen

What test are required ?

Go through steps described above and make sure the taxon number input field is cleared.

What documentation required?

None

Remarks

FedorSteeman commented 5 months ago

I cannot quite replicate this issue...

Steps in the process:

  1. Logged in to NHMA Entomology
  2. Entered taxon number '666'
  3. Taxon appears: "Amphisbatis incongruella (Stainton, 1849)"
  4. Saved record with barcode 000000002
  5. Entered new taxon name "Neotaxia irritans"
  6. Choose family "Nepticulidae" and clicked "OK"
  7. Taxon number '666' is replaced with '36' which corresponds to "Nepticulidae"

This a related but slightly different issue: Family's taxon number is transferred for any new taxon, instead of the taxon number being cleared.

I also noticed that the taxon number is not always cleared whenever I type in and select a known taxon.

Steps in the process:

  1. Logged in to NHMA Entomology
  2. Entered taxon number '400'
  3. Taxon appears: "Phyllonorycter quercifoliella (Zeller, 1839)"
  4. Saved record with barcode 000000003
  5. Searched for and selected alternative taxon name: "Phyllonorycter quinqueguttella (Stainton, 1851)"
  6. Taxon is transferred to field, but taxon number is not replace with the corresponding value of "433".

I will look more closely at these general issues with the taxon number and its interplay with the autosuggest box.

BTW I'd say the taxon field should also be cleared when the taxon number is.

FedorSteeman commented 5 months ago

@bhsi-snm noted that duplicates occurring and we concluded this may be because of no filtering on collection when searching for taxa.

FedorSteeman commented 5 months ago

@bhsi-snm noted that duplicates occurring and we concluded this may be because of no filtering on collection when searching for taxa.

Added filtering on taxon tree and institution id now to mitigate this particular issue in this commit: https://github.com/NHMDenmark/Mass-Digitizer/commit/da650e72271cda3df3ca102613ceb9fd1d7a4259

FedorSteeman commented 5 months ago

This a related but slightly different issue: Family's taxon number is transferred for any new taxon, instead of the taxon number being cleared.

I seem to have fixed this issue now.

FedorSteeman commented 5 months ago

BTW I'd say the taxon field should also be cleared when the taxon number is.

And this happening too now.

FedorSteeman commented 5 months ago

Choosing a known taxon also clears the taxon number for me. I'd say we're ready for a version v1.1.30 ...