NHMDenmark / Mass-Digitizer

Common repo for the DaSSCo team
Apache License 2.0
1 stars 0 forks source link

Tick boxes when specimen or label obscured #445

Closed PipBrewer closed 1 week ago

PipBrewer commented 8 months ago

Some discussion has been going on with the collection managers and digitisers, but it looks like we should make a note of instances in the Digi App where the specimens and/or label will not be able to be imaged as they are obscured (has implications for reports to collection managers, status and for transcription). In Specify, I was thinking that if we add them as separate lines in the remarks table using controlled terminology, we should be able to run reports on them to send to collection managers to review. However, in the App it might be easiest to have tick boxes for these.

PipBrewer commented 8 months ago

Sent email on 26/10/2023 to Fedor, Bhupjit and Jan asking whether it is theoretically possible to map notes from DigiApp to different lines in Remarks table in Specify.

Fedor's response: "Yes. If data like “Specimen Obscured” are separate tickboxes (or other kinds of input fields) that are stored into individual columns in the local app db then these can be sorted into columns that can be mapped to individual “Remarks” records (in reality: Collection Object Properties) associated with each specimen."

chelseagraham commented 8 months ago

just linking a ticket on the Herbarium board from which I can draw information relevant to this ticket https://github.com/NHMDenmark/Herbarium-Sheets-workstation/issues/55

chelseagraham commented 5 months ago

@Gomismis as per our meeting with Pip, please add decisions (from https://github.com/NHMDenmark/Herbarium-Sheets-workstation/issues/55) here, re-assign this ticket to Bhupjit, and then take this ticket off of our project board. Thank you.

chelseagraham commented 5 months ago

Current procedures (from @Gomismis document https://github.com/NHMDenmark/Herbarium-Sheets-workstation/issues/55) include

I will just wait until this is confirmed (as the ticket that this is dependent (https://github.com/NHMDenmark/Herbarium-Sheets-workstation/issues/55) on is not closed / completely resolved - needing input from @PipBrewer )

Confirmed by Pip

FedorSteeman commented 5 months ago

@bhsi-snm @PipBrewer Are the requirements of this ticket ready for me to start implementing, or who has the ball on this issue?

FedorSteeman commented 5 months ago

@chelseagraham What is the status?

chelseagraham commented 5 months ago

Confirming use of "Label Obscured" and "Specimen Obscured"

FedorSteeman commented 5 months ago

@chelseagraham Where on the UI are these two (?) tick boxes to be placed?

FedorSteeman commented 5 months ago

Placement specified here: https://github.com/NHMDenmark/Mass-Digitizer/issues/439#issuecomment-1934131095

FedorSteeman commented 5 months ago

I just talked with @chelseagraham and I believed that these tickboxes are to be mapped to flag fields. However, looking through the ticket specification I can see these are to be mapped to collection object remarks (properties), so will do that instead.

Teased out the tasks that are relevant to me:

FedorSteeman commented 4 months ago

@chelseagraham Should I group these checkboxes together as proposed and use the caption "Specimen Flags" as per below?

image

chelseagraham commented 4 months ago

I think this works well. As Rebekka mentioned, they are not mutually exclusive, so the check boxes makes the most sense. :)

AstridBVW commented 1 week ago

This ticket was closed prematurely. Steps were missed, there still need to be made changes to the GREL script and mapping to accommodate the mapping of "Specimen obscured" and "Label obscured" to the DaSSCo remarks table in Specify.

AstridBVW commented 1 week ago

The GREL script has now been updated and pushed to github. It has been set up in a similar fashion to the notes field with a remark, source and date. The remark is "Specimen obscured" and "Label obscured" respectively, the source is "DaSSCo digitisation", and the date is the same as the cataloged date.

The mapping to the remarks table will be added with the next import.