NHMDenmark / Mass-Digitizer

Common repo for the DaSSCo team
Apache License 2.0
1 stars 0 forks source link

Can't create new taxa without author if that taxon already exists with an author #466

Closed RebekkaML closed 5 months ago

RebekkaML commented 5 months ago

Describe the bug

When entering a taxon into the DigiApp, the Author of that taxon is not always given on the specimen label, e.g. it is only called "Allium scorodoprasum", but the DigiApp only suggests that taxon with an Author: "Allium scorodoprasum L." When I try to create a new taxon without the "L." it always automatically autocompletes it back again, I cannot unselect it in the dropdown menu. There used to be a workaround for this (add two spaces and delete them again later I think), but this doesn't seem to work anymore. This is only a problem in cases where the taxon name without author isn't already imported yet.

To Reproduce Steps to reproduce the behavior: In DigiApp NHMD Vascular Plants, go to taxonomic name and try to enter only "Allium scorodoprasum". It doesn't work, it always autocompletes it to "Allium scorodoprasum L.".

Expected behavior A clear and concise description of what you expected to happen. There should be a way to newly create taxon names of which a longer version already exists.

Screenshots If applicable, add screenshots to help explain your problem. GitHub Issue

Please complete the following information:

bhsi-snm commented 5 months ago

@RebekkaML last time i encoutered this, there was a way to click on the auto suggest close button and save the record to do it, and then it created the new taxa. did you try that?

bhsi-snm commented 5 months ago

@FedorSteeman might be worth looking into @RebekkaML confirmed that closing the autosuggest leaves the taxa field empty, so this might be a problem.

FedorSteeman commented 5 months ago

I see. Good this was caught.

PipBrewer commented 5 months ago

Can confirm that it is not possible to add name if it is part of a existing one (e.g., if the author is not stated in association with the taxon name). This is also captured in #257 (in backlog). If there is no easy way of doing this, perhaps we could add a character to all new names.

FedorSteeman commented 5 months ago

I can see three ways of solving this:

  1. For each taxon name, add entries without author names to the taxon spine
  2. Avoid selection of top result in autosuggest box by pressing "Escape"
  3. In cases where a choice is forced, the digitizer could add an asterisk to escape this situation

I do not recommend 1, because we actually would like the taxon spine to hold actual taxa i.e. including the author name, and not deficient ones without that.

The problem with 2 is that the taxon name should really be marked as a new taxon including allowing the possibility off adding family name.

Solution 3 could work if the digitizers are informed of this options and the code filters out the asterisk again.

So therefore I suggest solution 3.

FedorSteeman commented 5 months ago

Closing this ticket so the fix can be evaluated. If a different solution is desired, it can be reopened.

jlegind commented 5 months ago
FedorSteeman commented 5 months ago

Sounds like the wrong version then, as I did change the version number for the release in question. Try again with release v1.1.28.