NHMDenmark / Mass-Digitizer

Common repo for the DaSSCo team
Apache License 2.0
1 stars 0 forks source link

Taxon SPID not persisted in the local DB specimen table #475

Closed jlegind closed 7 months ago

jlegind commented 8 months ago

Describe the bug When testing the Digi app the property taxonspid is not applied in the specimen table.

To Reproduce Steps to reproduce the behavior:

  1. Log in to the DaSSCo digi app
  2. Fill out the form and save
  3. Check the specimen table in DBBrowser viewer
  4. See that the taxonspid is always set to 0

Expected behavior The taxonspid is derived from a spid column and should have a number.

Please complete the following information:

Export file specimenTable.xlsx

Additional context The post processing GREL script relies on the taxonspid to identify novel taxon names. A 0 signifies a new taxon and the 'newtaxon' flag will be set.

Possible solution We could rely on the remarks field to look for this pattern: | Verbatim_taxon: the_novel_name

FedorSteeman commented 8 months ago

Could you include some sample exports?

jlegind commented 8 months ago

Linked in the original post.

FedorSteeman commented 8 months ago

The taxonspid is not set, because in those cases there is no Specify ID, since the taxon is unknown to Specify. It is, however, known in the taxon spine and should therefore not be marked as a "new taxon" to be investigated by staff.

So the following needs to be happen:

FedorSteeman commented 7 months ago

The needed changes to the GREL script have been dealt with using fix https://github.com/NHMDenmark/Mass-Digitizer/commit/21a569fb0a34565e7e130293fb7857d617f7ec30

@jlegind Could you please test this again?