Author names not carried over in the post processed file (GREL)

NHMDenmark / Mass-Digitizer

Common repo for the DaSSCo team

Apache License 2.0

1 stars 0 forks source link

Author names not carried over in the post processed file (GREL) #476

Closed jlegind closed 7 months ago

jlegind commented 8 months ago

Describe the bug Using mock data with taxon names having author names (the new taxonomy) in the export file, the author part of the name is not added to the species name.

To Reproduce Steps to reproduce the behavior:

Create mock export file in the Digi app.
Import into Open refine
Apply the post processing GREL script https://github.com/NHMDenmark/Mass-Digitizer/blob/main/OpenRefine/post_processing.json
Observe the output file

Expected behavior If any: Author name added to the lowest taxon rank.

Please complete the following information:

version 1.1.24
Specify has an Author field in the 'taxon' table. This could be a part of the solution.

If the author name was split into its own field in the initial export from the Digi app, I suppose it would be a trivial matter to map it to the Specify taxon table 'Author' column.

FedorSteeman commented 8 months ago

Fixed with commit https://github.com/NHMDenmark/Mass-Digitizer/commit/bb5b3a44556aa37354f372619e4eaa2fc5a8aa59 also mentioned here: https://github.com/NHMDenmark/Mass-Digitizer/issues/434#issuecomment-1927871407

FedorSteeman commented 8 months ago

To be tested with pre-release: https://github.com/NHMDenmark/Mass-Digitizer/releases/tag/v1.1.26

NOTE: We have not yet considered the author name of any new taxa...

jlegind commented 7 months ago

Testing author name:

The taxonauthor column in the specimen table is not populated with the author name of an existing name having an author.
The post processing loses that column (taxonauthor) when running the GREL script.

FedorSteeman commented 7 months ago

The GREL script needs to be adapted as to create separate columns for the author name of each rank and also these columns should be retained in the final re-ordering. Then these author name columns can be mapped in Specify for each taxon rank.

FedorSteeman commented 7 months ago

I could not replicate: "The taxonauthor column in the specimen table is not populated with the author name of an existing name having an author."

However, I adapted the script to deal with the taxon author names.

@jlegind Could you test this again?

FedorSteeman commented 7 months ago

New release ready for testing: https://github.com/NHMDenmark/Mass-Digitizer/releases/tag/v1.1.28