search

NHMDenmark / Mass-Digitizer

Common repo for the DaSSCo team
Apache License 2.0
1 stars 0 forks source link

Saving notes in the digi app does not work correctly #486

Closed AstridBVW closed 4 days ago

AstridBVW commented 4 months ago

Describe the bug While digitising we are having problems with information added to the notes field in the digi app not being saved even though the "SAVE" button is used.

To Reproduce Steps to reproduce the behavior:

  1. Log into the digi app and fill out the standard fields (screenshot 1)
  2. Scan a barcode
  3. The digi app automatically saves and goes on to the next one. Click on "GO BACK"
  4. Move the cursor to the Notes field and scan the controlled vocabulary data matrix for "Associated preparation slide #" to add it to the field. Add the slide number after "#" by typing. Then click "SAVE" (screenshot 2)
  5. Go to the database in DB Browser for SQLite and refresh.
  6. Navigate to the notes column in the database. Here you will see that only the information from the data matrix was saved and not the slide number (screenshot 3)
  7. Go to the digi app and click on "SAVE" again.
  8. Go to the database in DB Browser for SQLite and refresh. You will now see that the slide number is saved as well (screenshot 4)

Expected behavior I expected all of the information in the notes field to be saved by clicking on the "SAVE" button once.

Screenshots

Skærmbillede 2024-02-15 112414 Skærmbillede 2024-02-15 112641 Skærmbillede 2024-02-15 112615 Skærmbillede 2024-02-15 112717

Please complete the following information:

Additional context The steps above are what happened while I was digitising (AstridBVW). I also tried adding information to the notes field BEFORE scanning the barcode and then the information was saved correctly. @RebekkaML also looked into this while digitising and figured out some more. She found the same as me when adding information to the notes field and then scanning the barcode, but she also found that if you scan the barcode, click "GO BACK", add the information to the notes field, move the cursor to the barcode field and then click"SAVE", it saves correctly. So it seems to be a problem relating to some rule about the barcode field and saving.

FedorSteeman commented 2 months ago

Debugging version 1.2.0 I could not reproduce the phenomenon as it immediately saves the whole value upon the first save:

image

@AstridBVW Could you please test again in version 1.2.0 ?

NOTE: I did not have a "controlled vocabulary data matrix" to use, so maybe that is the factor that makes a difference here...

PipBrewer commented 1 month ago

Check latest version of App and try and reproduce with and without data matrix

AstridBVW commented 4 days ago

I have assigned this to @RebekkaML instead. She is familiar with this ticket and have a version of the app on her computer that she can use for testing (I have a mac).

RebekkaML commented 4 days ago

I tested this in version 1.2.0 and could not reproduce this error there either. I tried it both with the "controlled vocabulary data matrix" and by typing the comment manually, and both worked fine. It also didn't make a difference whether I entered the comment first and then the barcode or entered the barcode, saved it and the clicked "GO BACK" to enter the comment, it appeared correctly in the database in all cases. It appears this bug was fixed with the latest version of the app.