NHMDenmark / Mass-Digitizer

Common repo for the DaSSCo team
Apache License 2.0
1 stars 0 forks source link

Add new taxa verbatim if unknown #68

Closed FedorSteeman closed 1 year ago

FedorSteeman commented 2 years ago

Issue

The handling of unknown taxon names being entered.

During taxon entry as per #2: If the taxon is not already in the taxon spine, it should be possible to add it verbatim. The staff digitizer finishes typing the name but the taxon spine options have been exhausted == New Name Eventually novel names can be separated out by looking for names NOT having a specify_ID.

Use case:

PipBrewer commented 1 year ago

@chelseagraham When digitiser types in part of a taxon name into digi app and there are no matches, they should then enter the full binomial name in a set format and press enter. That will activate a second pop up box asking digitiser to enter the family. If the family is not there, press cancel and type the family into the notes field. CANCEL HAS IMPLICATIONS HERE. This is all for adding to workflow.

FedorSteeman commented 1 year ago

Skipped one task, because we didn't make it and also, in retrospect, it seems counterintuitive.

Will reanimate upon request.

PipBrewer commented 1 year ago

Not sure why this has not been implemented? Can we add it back in?

FedorSteeman commented 1 year ago

We couldn't make it. Also, the new name should actually already be added to the specimen record anyway, namely in the taxonname and taxonfullname columns of the specimen table, even without a corresponding record in the taxonname table. So the name is recorded in the specimen record. Not sure why it should be put in the notes field then.

FedorSteeman commented 1 year ago

Testing the beta 2.2 we realized that it's actually not currently possible to skip adding a higher taxon.

So in order to meet the requirement it should be possible to leave the popup's higher taxon name field empty and then the taxon full name being added verbatim to the specimen record, but no new record in the taxon name.

I suggest the following use case alternatives to accomplish the above:

  1. Just pressing 'enter' without entering anything in the higher taxon name field in the popup
  2. A 'cancel' button for explicitly skipping the entry of a higher taxon (safer and clearer)

Again: Since we can add the taxon name to the record verbatim, there's no need to add it to the notes field, but that can be done too, if deemed preferable.

FedorSteeman commented 1 year ago

I discovered another glitch with higher taxon lookup and that is that it's not filtering on minimum rank, i.e. it should only look for families and higher when suggestion higher taxa. If this glitch is a major problem (as is with the above) then we can compile and release a new beta soon.

FedorSteeman commented 1 year ago

I've manage to implement the Cancel button to try it out and it appears to work fine. It records the taxon name and leaves the higher taxon name empty when clicked.

image

I can push this change to a new beta 2.3 if desired in short notice.

jlegind commented 1 year ago

In the case of a novel taxon name and a novel higher taxon name (family rank): This data is added to the specimen record AND a new taxon entry is inserted into the taxonname table.
In the case of a novel taxon name having a known higher taxon name (family rank): This data is added to the specimen record AND a new taxon entry is inserted into the taxonname table.

FedorSteeman commented 1 year ago

New derived ticket created here #211

jlegind commented 1 year ago

Algorithm: