search

NHSLeadership / nightingale-wp

Other
1 stars 0 forks source link

Fix burger menu #57

Closed Android63 closed 6 years ago

Android63 commented 7 years ago

Implement fix to burger menu (nightingale issue #108

Android63 commented 7 years ago

After using the new JS code from Nightingale, the menus stop working properly. Any ideas anyone?

If you look at this screenshot, you'll see the last 2 menu items (which have sub-menus) have been bunched up against the login button. More importantly, clicking on one of these menu items has no effect: the sub-menu doesn't open.

screen shot 2017-09-06 at 16 49 28
Android63 commented 7 years ago

This is how it should look (and did look before this update):

screen shot 2017-09-06 at 17 00 10
cehwitham commented 7 years ago

@Android63 has the markup changed in Nightingale? Is the code still referenced correctly?

Any errors in Console?

Android63 commented 7 years ago

I think I've found the problem. In my current markup, the subnav elements are included in the main nav div, whereas they should be after it. Reworking it now...

Android63 commented 7 years ago

Waiting for https://github.com/NHSLeadership/nightingale/pull/165

Android63 commented 6 years ago

Since https://github.com/NHSLeadership/nightingale/issues/108 and https://github.com/NHSLeadership/nightingale/pull/165 have been completed, this is now resolved.