search

NHSLeadership / nightingale-wp

Other
1 stars 0 forks source link

Tkt 00057 #59

Closed Android63 closed 6 years ago

Android63 commented 7 years ago

I copied the js from index.html in Nightingale, but agree it should be in a separate file that we can all reference. Happy to move it.

cehwitham commented 7 years ago

This will enable it https://github.com/NHSLeadership/nightingale/issues/104

Android63 commented 7 years ago

I've fixed this in NHSLeadership/nightingale#104 so, once that's merged, I'll update the WordPress theme to reference the files in node_modules.

Android63 commented 7 years ago

I'm now referencing the files in Nightingale. If that looks OK, I'd like to merge @cehwitham

cehwitham commented 6 years ago

@Android63 is this PR still required or can it be removed?

Android63 commented 6 years ago

I was waiting for https://github.com/NHSLeadership/nightingale/pull/165 to be approved before closing this. But maybe that's not necessary @cehwitham

cehwitham commented 6 years ago

Happy for you to merge that then merge this @Android63