search

NHSLeadership / nightingale-wp

Other
1 stars 0 forks source link

Tiled gallery #71

Open Android63 opened 6 years ago

Android63 commented 6 years ago

Format a tiled gallery of images so they appear as a grid

Android63 commented 6 years ago

Nightingale doesn't have a tiled gallery. Should it? Let's discuss @cehwitham and @Pro-Paul

cehwitham commented 6 years ago

This is the default WordPress gallery layout: https://codex.wordpress.org/The_WordPress_Gallery

We've also used tiled galleries on a previous setup: https://jetpack.com/support/tiled-galleries/

Not sure how much use case there is for galleries over single images but I think articles like graduation ceremonies would benefit.

What are your thoughts @Pro-Paul ?

penpadstudio commented 6 years ago

Hi,

Just to weigh in here quickly.

There may well be a use case here but not one I can see as being a high enough priority at the moment to be implemented in version 1.

I would suggest that this can be reviewed properly for implementation once we have a closer close to implementation of v1 and look to add the feature in or even replace one we do some user testing with the first iteration of v1.

So I suggested to keep on the back burner for now.

Android63 commented 6 years ago

I'm happy to put this on the back-burner but what if a site admin adds a gallery? At the moment, it won't look good. Is that OK @cehwitham?

cehwitham commented 6 years ago

How bad does it look @Android63 ?

Android63 commented 6 years ago

The images are in one column @cehwitham, no matter how many columns are set:

screen shot 2018-02-02 at 15 16 43

cehwitham commented 6 years ago

I agree with Paul, we don't want to make this a big thing but I wonder if there's a quick win mapping the existing column classes to the WP markup? Wouldn't want to spend more than an hour on it.

Android63 commented 6 years ago

That's my think too @cehwitham. I'll take a look...