Open Android63 opened 6 years ago
Following discussion with @Pro-Paul, here are the requirements for desktop layout of the header:
The header should have a top margin of 30px and a bottom margin of 15px (class = c-page-header).
The logo, which could be of any size, should be left-aligned (class = c-page-header__lockup).
The controls column, which may contain a search bar, menu bar and login button, should be 632px wide and right-aligned in its container (class = c-page-header__controls).
The search bar, if present, should be 38px high and should occupy 100% of its column width (class = c-search).
The menu bar, if present, should have a height of 19px and should be left-aligned in its column with a 15px top margin if a search bar is present and 53px if not (class = c-nav-primary).
This should result in the menu items vertically aligning with the first line of text in the logo. Since the logo is (currently) an image, this will be impossible to control in markup.
The login button, if present, should be 84px by 36px and should be right-aligned in its column with a 10px top margin if a search bar is present and 48px if not (class = c-btn--primary)
Presumably, this is markup related @Android63? If the markup matches Nightingale, then the layout should too?
Yes indeed @cehwitham. Awaiting https://github.com/NHSLeadership/nightingale/pull/185
Since https://github.com/NHSLeadership/nightingale/pull/185 is now complete, this issue can be addressed.
Address points raised by @Pro-Paul at https://github.com/NHSLeadership/nhsl-wp-ldphub/issues/13